https://bugzilla.redhat.com/show_bug.cgi?id=1581240 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - Use the %configure macro instead of ./configure - Use %{_prefix} instead of /usr and %{_usr} %if %{debug} == 1 prefix=/usr --debug %else prefix=/usr --symbols %endif %define plugindir %{_usr}/lib/%{name}/plugins - Don't comment out %install #%%install - Add a changelog entry - Separate the license by "and": License: GPLv2+ and LGPLv2+ and BSD - Shouldn't the plugins be in /usr/lib64 on 64bits arches? - Install the license file COPYING in %files and add the %doc too: %files core %license COPYING %doc README Changelog AUTHORS Release_notes I can't sponsor, try introducing yourself to the devel mailing list and do some informal reviews to show you understand the guidelines and to find a sponsor. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/TOSYJPA3AHVUFEKQ76U43PSECHDTBF7D/
