https://bugzilla.redhat.com/show_bug.cgi?id=1582876 --- Comment #2 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- URL and Source addresses are Ok. Source archive (SHA-256: 12605c10fc4649a5b9e2bcda6960ec39e498ea25e060db4362c926de4594e590) is original. Ok. Summary verified from lib/Diff/LibXDiff.pm. Ok. Description verified from lib/Diff/LibXDiff.pm. Ok. License verified from lib/Diff/LibXDiff.pm and README. Ok. No XS code, noarch BuildArch is Ok. All tests pass. Ok. $ rpmlint perl-Diff-LibXDiff.spec review-perl-Diff-LibXDiff/results/perl-Diff-LibXDiff-0.05-1.fc29.src.rpm review-perl-Diff-LibXDiff/results/perl-Diff-LibXDiff-0.05-1.fc29.x86_64.rpm perl-Diff-LibXDiff.spec:21: W: unversioned-explicit-provides bundled(libxdiff) perl-Diff-LibXDiff.src:21: W: unversioned-explicit-provides bundled(libxdiff) 2 packages and 1 specfiles checked; 0 errors, 2 warnings. Please specify the version of the bundled libxdiff (0.23). Please use DESTDIR instead of PERL_INSTALL_ROOT. $ rpm -q -lv -p perl-Diff-LibXDiff-0.05-1.fc29.x86_64.rpm drwxr-xr-x 2 root root 0 mai 29 19:36 /usr/lib/.build-id drwxr-xr-x 2 root root 0 mai 29 19:36 /usr/lib/.build-id/d8 lrwxrwxrwx 1 root root 70 mai 29 19:36 /usr/lib/.build-id/d8/221f1486f1e9bde59cbf9c62a648ab841699a6 -> ../../../../usr/lib64/perl5/vendor_perl/auto/Diff/LibXDiff/LibXDiff.so drwxr-xr-x 2 root root 0 mai 29 19:36 /usr/lib64/perl5/vendor_perl/Diff -rw-r--r-- 1 root root 5215 avril 21 2010 /usr/lib64/perl5/vendor_perl/Diff/LibXDiff.pm drwxr-xr-x 2 root root 0 mai 29 19:36 /usr/lib64/perl5/vendor_perl/auto/Diff drwxr-xr-x 2 root root 0 mai 29 19:36 /usr/lib64/perl5/vendor_perl/auto/Diff/LibXDiff -rwxr-xr-x 1 root root 57904 mai 29 19:36 /usr/lib64/perl5/vendor_perl/auto/Diff/LibXDiff/LibXDiff.so drwxr-xr-x 2 root root 0 mai 29 19:36 /usr/share/doc/perl-Diff-LibXDiff -rw-r--r-- 1 root root 433 avril 21 2010 /usr/share/doc/perl-Diff-LibXDiff/Changes -rw-r--r-- 1 root root 2675 avril 21 2010 /usr/share/doc/perl-Diff-LibXDiff/README -rw-r--r-- 1 root root 2320 mai 29 19:36 /usr/share/man/man3/Diff::LibXDiff.3pm.gz File permissions and layout are Ok. $ rpm -q --requires -p perl-Diff-LibXDiff-0.05-1.fc29.x86_64.rpm | sort -f | uniq -c 19:43:01 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libperl.so.5.26()(64bit) 1 libpthread.so.0()(64bit) 1 libpthread.so.0(GLIBC_2.2.5)(64bit) 1 perl(:MODULE_COMPAT_5.26.2) 2 perl(Carp::Clan) 1 perl(DynaLoader) 1 perl(Exporter) 1 perl(strict) 1 perl(Test::More) >= 0.42 1 perl(Test::Most) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rtld(GNU_HASH) Please explain why you've added: Requires: perl(Test::More) >= 0.42 Requires: perl(Test::Most) They don't seem necessary for the package to work, they're only used for the tests. Also you need to add gcc as a BR since it will be removed from the buildroot. $ rpm -q --provides -p perl-Diff-LibXDiff-0.05-1.fc29.x86_64.rpm bundled(libxdiff) perl(Diff::LibXDiff) = 0.05 perl-Diff-LibXDiff = 0.05-1.fc29 perl-Diff-LibXDiff(x86-64) = 0.05-1.fc29 Binary provides are Ok. Package builds in F28 (https://koji.fedoraproject.org/koji/taskinfo?taskID=27284941) Ok Please address all the points mentioned above. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/TRIXZSH5C7HQ4WBXOZVM5HZIPLCWME63/
