https://bugzilla.redhat.com/show_bug.cgi?id=1577011 --- Comment #4 from Vaughan <devel@xxxxxxxxx> --- Hi Peter, thanks for the review. Please see below for commits / comments. (In reply to Peter Oliver from comment #3) > Issues: > ======= > - Dist tag is present. Use %{?dist} instead of %{dist}. See > https://fedoraproject.org/wiki/Packaging:DistTag DONE https://github.com/agrez/wiringpi/commit/6e53a3b22548372f66d3e7d5e23c20407d212151 > - Development (unversioned) .so files in -devel subpackage, if present. > Note: Unversioned so-files directly in %_libdir. > See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages > Files /usr/lib/libwiringPi.so and /usr/lib/libwiringPiDev.so are present > in both the libs and devel subpackages, but should only be in the devel > subpackage. DONE https://github.com/agrez/wiringpi/commit/02e43e63fc44373cc19e03f2b5e6b7ac1fac0e65 > - ldconfig called in %post and %postun if required. > Note: /sbin/ldconfig not called in wiringpi-libs > See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries > On Fedora 27 and earlier, a post-install scriptlet is required in the libs > subpackage. DONE https://github.com/agrez/wiringpi/commit/fadf83b45da31b5c2af25b693600ec90ef47c117 > - Package uses hardened build flags if required to. > Note: suid files: gpio and not %global _hardened_build > See: > http://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/ > Guidelines#Compiler_flags DONE https://github.com/agrez/wiringpi/commit/3fc96c13b755ca543f835cf52a1b943201ff91e1 > - The licence can be left out of the main and devel subpackages, since both > depend on libs, which also contains the licence. DONE https://github.com/agrez/wiringpi/commit/85d5651d9fad86a883ffa69812f9168e0f6683f5 > - The devel subpackage should mention %{?_isa} when it requires the libs > subpackage. Perhaps the main package should require the libs subpackage in > the same way. > https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/ > Guidelines#Requiring_Base_Package DONE https://github.com/agrez/wiringpi/commit/28cbb1352e77ee2f261fbccb0a935428f0ac8270 > - Can this be built on all ARM flavours? ExclusiveArch could be set to > %{arm} if so. Do you want to know if it works on aarch64 too? I haven't actually tested wiringpi on aarch64 (as you would need aarch64 BCM270x Linux kernel port, which I haven't ever built), so I don't know if it works. Anyway, I updated the spec and makefile patch to add aarch64 build support. Koji scratch builds seem to build ok. https://github.com/agrez/wiringpi/commit/db7bc872556ec98f5c82e443f48f51bed8c061da > - rpmlint suggests that “WiringPi is” is left off the start of the Summary. DONE https://github.com/agrez/wiringpi/commit/79899f3c3956eddc6396f32868c52e49618c875a > - Commit 8d188fa of WiringPi is tagged as version 2.46, which means the > “release version” guidelines rather than the “snapshot” guidelines of > https://fedoraproject.org/wiki/Packaging:Versioning should be followed > (i.e., “.git%{commit_short}” can removed). DONE https://github.com/agrez/wiringpi/commit/229325a65f607de4b622249fa499cc6ff0cc75eb > - It might be nice to install the examples as documentation in the devel > package. DONE https://github.com/agrez/wiringpi/commit/a5774441b5da91b2d626adab003479241c90e601 > - Could some of the Makefile changes be submitted upstream? > Yes, ok I can ask upstream and see if the maintainer is receptive. Updated Spec URL: https://raw.githubusercontent.com/agrez/wiringpi/master/wiringpi.spec Update SRPM URL: https://github.com/agrez/wiringpi/releases/download/2.46-1/wiringpi-2.46-1.fc28.src.rpm koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=26913836 Cheers! Vaughan -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
