https://bugzilla.redhat.com/show_bug.cgi?id=1564716 --- Comment #2 from Michal Ambroz <rebus@xxxxxxxxx> --- Spec URL: http://rebus.fedorapeople.org//dionaea.spec SRPM URL: http://rebus.fedorapeople.org//dionaea-0.6.0-5.20180326git1748f3b.fc27.src.rpm Hello Robert Andre, thank you very much for the review. >- Group: is not needed in Fedora It is not prohibited and still needed for EPEL which I plan to support. >- Use %{?systemd_requires} instead of: OK >- Doc package should be noarch and just be named: OK changed >- Not needed at the end of build: cd .. I believe it is a good habit whend doing cd "somewhere" during build, then to change directory back again. Just in case somebody would need to add there some more post-build commands >- Install of the man page should not be to %{name}.1.gz but %{name}.1 OK changed > - Use {_sharedstatedir} instead of %{_var}/lib OK changed > - Not needed: %clean OK - removed >- Instead of: %{dir} , Just do: ..../ OK - changed > - Don't use: %{_mandir}/man1/%{name}.1.* OK - Changed >- Remove sphinx-build leftovers: OK - removed -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
