Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libedit - The NetBSD Editline library https://bugzilla.redhat.com/show_bug.cgi?id=274891 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-09-03 05:55 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and RPM. + source files match upstream. e8abd1169825efecfccb0f7b4c338bb5 libedit-20070831-2.10.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is small so no need of -doc subpackage. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + libedit.pc files are present. + -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + ldconfig scriptlets are used. + libedit package -> Provides: libedit.so.0 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.2) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libedit.so.0 libncurses.so.5 rtld(GNU_HASH) +libedit-devel package -> Requires: libedit = 2.10-1.20070831cvs.fc8 libedit.so.0 ncurses-devel pkgconfig + Not a GUI app. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review