Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libtune - standard API to access the kernel tunables https://bugzilla.redhat.com/show_bug.cgi?id=210007 ------- Additional Comments From adel.gadllah@xxxxxxxxx 2007-08-30 10:00 EST ------- Ok, some other issues with the spec file: >%define base_kernel %(rpm -q --queryformat='%{VERSION}' --whatprovides >kernel-headers) >%define family FC >%define frelease %(rpm -q --queryformat='%{VERSION}' fedora-release) >%define distro_string %{family}%{frelease} seems like the only one used from them is the "base_kernel" drop the other ones and use uname -r instead of rpm to get the kernel version; this also means you have to require the extact kernel version it is build against or isn't this needed? ---------------- >License: GPL/LGPL the license guidlines changed please see: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines and http://fedoraproject.org/wiki/Licensing ----------------- Remove the dot from the end of the description ----------------- use %{dist} for distro_string ----------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review