Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libflaim - Flaim Database Engine https://bugzilla.redhat.com/show_bug.cgi?id=251020 opensource@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |opensource@xxxxxxxxx ------- Additional Comments From opensource@xxxxxxxxx 2007-08-30 09:50 EST ------- - static libraries should be in a -static package or not packaged at all: %{_libdir}/libflaim.a - see: http://fedoraproject.org/wiki/Packaging/Guidelines#head-2302ec1e1f44202c9cc4bcce24cb711266557ad7 - - MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory ownership and usability). -> Add Reuires: pkgconfig to %package devel - you should use $RPM_OPT_FLAGS instead of %optflags: http://fedoraproject.org/wiki/Packaging/Guidelines#head-f3d77b27a5d29dfc1f5600ef3fc836f2e317badf -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review