https://bugzilla.redhat.com/show_bug.cgi?id=1552979 --- Comment #6 from Matt Tyson <mtyson@xxxxxxxxxx> --- (In reply to Itamar Reis Peixoto from comment #4) > > the counterpart thttpd has been removed from Fedora because no one cared > about it, I think this package will have the same future. I'm a developer on Beaker ( https://beaker-project.org/ ) and thttpd is used as part of our automated test suite on the Fedora build machines. thttpd was dropped from Fedora before I joined Beaker and it's now a bit of a pain point in our automated provisioning system. If there's any issues in this package I will be happy to address them. > > if the intention is only to get in @fedora-packager fas group, I think > filling a ticket here should be better, > That was not my intention. (In reply to Zbigniew Jędrzejewski-Szmek from comment #5) > Yeah, the sysusers macro shouldn't be used just yet. > > Source0 should be a full URL. Where should I point this to? I'm only aware of the github page. I have not been able to find an official tarball release. Only a git repo tag. > > Requires: systemd → %?systemd_requires > [https://fedoraproject.org/wiki/Packaging:Scriptlets#Systemd] Done > > %setup -q + %patch0 -p1 → %autosetup -p1 Done > > %{__perl} → perl [https://fedoraproject.org/wiki/Packaging:Guidelines#Macros > only suggests macros for directories, there is no reason to obfuscate > executable names like that] Changed to /usr/bin/perl > > /var/run → /run [https://fedoraproject.org/wiki/Packaging:Guidelines#.2Frun] Done > > make %{?_smp_mflags} → %make_build > Done > You shouldn't use %{SOURCE1} in the scriptlets definitions, because it might > be a full path. Use just the name of the service. > %systemd_post %{SOURCE1} → %systemd_post thttpd.service Done. Thank you for the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
