https://bugzilla.redhat.com/show_bug.cgi?id=1552979 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@xxxxxxxxx Summary|Review Request: sthttpd - |Review Request: sthttpd - |Tiny http server. |Tiny http server --- Comment #5 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- Yeah, the sysusers macro shouldn't be used just yet. Assuming that you actually want sthttpd in Fedora, here's my review: Source0 should be a full URL. Requires: systemd → %?systemd_requires [https://fedoraproject.org/wiki/Packaging:Scriptlets#Systemd] %setup -q + %patch0 -p1 → %autosetup -p1 %{__perl} → perl [https://fedoraproject.org/wiki/Packaging:Guidelines#Macros only suggests macros for directories, there is no reason to obfuscate executable names like that] /var/run → /run [https://fedoraproject.org/wiki/Packaging:Guidelines#.2Frun] make %{?_smp_mflags} → %make_build You shouldn't use %{SOURCE1} in the scriptlets definitions, because it might be a full path. Use just the name of the service. %systemd_post %{SOURCE1} → %systemd_post thttpd.service -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
