Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Ice - The Internet Communications Engine (Object middleware) https://bugzilla.redhat.com/show_bug.cgi?id=234612 ------- Additional Comments From mefoster@xxxxxxxxx 2007-08-29 12:13 EST ------- (In reply to comment #53) > I checked the left 917 files manually and they > are all okay (some of them are demo files or so > and are never used...) Wow! I'm impressed ... thanks for that, and for accepting the package. I made the license change. Meanwhile, I only just now noticed that I'd been putting the Ruby stuff into a subdirectory where it didn't actually work, so I fixed that. On rereading the Ruby packaging guidelines, I also added Provides: Ruby(Ice) = %{version} to the ruby package. (According to those guidelines, the package "must" also apparently be called "ruby-ice", not "ice-ruby", but I don't really want to do that.) Don't know if you want to look over these changes too ... http://homepages.inf.ed.ac.uk/mef/extras/ice-3.2.1-9.fc7.src.rpm http://homepages.inf.ed.ac.uk/mef/extras/ice.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review