[Bug 199154] Review Request: Slony-1 (postgresql-slony-engine)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Slony-1 (postgresql-slony-engine)


https://bugzilla.redhat.com/show_bug.cgi?id=199154





------- Additional Comments From devrim@xxxxxxxxxxxxxxxxx  2007-08-29 03:30 EST -------
Hi,

(In reply to comment #24)
> > See configure file for this.
> 
> You mean the PACKAGE_NAME?
> The tarball is slony1-1.2.10.tar.bz2, the upstream project is called Slony-I,
and the first line of the README file says Slony-I. From 
> the NamingGuidelines:
> When naming a package, the name should match the upstream tarball or project
name from which this software came.

Ok, I committed a bunch of fixes to Slony-I:

http://lists.slony.info/pipermail/slony1-commit/2007-August/001953.html
http://lists.slony.info/pipermail/slony1-commit/2007-August/001954.html
http://lists.slony.info/pipermail/slony1-commit/2007-August/001955.html
http://lists.slony.info/pipermail/slony1-commit/2007-August/001956.html
http://lists.slony.info/pipermail/slony1-commit/2007-August/001957.html


> > Missing yacc parser.y parser.c
> >> ? No idea what this means.
> yacc is provided by bison, and seems to be used by Slony-I:
http://www.gnu.org/software/bison/

Ok, added as BR.
 
> > - Since postgresql_autodoc is now available, maybe you can add it to the
BuildRequires
> >> I don't think so. Is there anything that depends on autodoc?
> 
> configure is searching for it, so I assume it is used.

It is not a must... But ok, added it.

> > Some people may skip doc builds.
> But doc is a separate package in Fedora, and people can just choose to not
install it.

I will make this change, since AFAIR RHEL 5, Fedora 6,7 and 8 does not have the
NAMELEN problem. I won't push it to RHEL 4.

> > Slony looks for /usr/local/pgsql/bin/pg_config first. If someone has a
source installation of PostgreSQL, then the build will break
> 
> This won't be a problem when the package is build on the Fedora buildservers.
I understand that you want to maintain one upstream 
> specfile for all versions of Red Hat and Fedora, but having a clean spec in
Fedora makes things more easier in the long run.

Yes, I want to maintain 1 spec file. If this is not a blocker, I would like to
skip it.

> A few other comments:
> 
> - Double BuildRequires for docbook-style-dsssl

Good catch :) Removed.

> - Is %kerbdir still needed? If not, there's no need to change CFLAGS, CXXFLAGS
and CFLAGS and a simple %configure will do.
>

%kerbdir is broken in RHEL3, that's why we keep it. Yes, one spec file for all
platforms :)

> rpmlint of postgresql-slony1-engine-docs:
> E: postgresql-slony1-engine-docs non-standard-dir-perm
/usr/share/doc/postgresql-slony1-engine-docs-1.2.10/support 0644
> E: postgresql-slony1-engine-docs non-standard-dir-perm
/usr/share/doc/postgresql-slony1-engine-docs-1.2.10/adminguide 
> 0644
> E: postgresql-slony1-engine-docs non-standard-dir-perm
/usr/share/doc/postgresql-slony1-engine-docs-1.2.10 0644
> E: postgresql-slony1-engine-docs non-standard-dir-perm
/usr/share/doc/postgresql-slony1-engine-docs-1.2.10/concept 0644
> E: postgresql-slony1-engine-docs non-standard-dir-perm
/usr/share/doc/postgresql-slony1-engine-docs-1.2.10/howto 0644
> E: postgresql-slony1-engine-docs non-standard-dir-perm
/usr/share/doc/postgresql-slony1-engine-docs-
> 1.2.10/implementation 0644

Some of them are fixed. However... 1.2.11 was already released, and I committed
the changes after that :( That may mean that we will wait another release to
test some of the changes.

I will post the updated srpm and spec file shortly.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]