https://bugzilla.redhat.com/show_bug.cgi?id=1526056 --- Comment #8 from Vít Ondruch <vondruch@xxxxxxxxxx> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #7) > > # Fix shebang. > > sed -i 's|/usr/bin/env ruby|/usr/bin/ruby|' %{buildroot}%{gem_instdir}/bin/asciibinder > This might not be necessary with the recent shebang rewriting that has been > turned on in rawhide. Still needed in lower releases... Indeed. That change landed in Fedora 29th. I will drop this. > > git config --global user.email "you@xxxxxxxxxxx" > > git config --global user.name "Your Name" > Is this necessary? Yes, it is. Git fails when these are not set and git is essential part of ascii_binder workflow and therefore test suite fails without this setup. > rubygem-ascii_binder-doc.noarch: W: spelling-error Summary(en_US) ascii -> > ASCII > rubygem-ascii_binder-doc.noarch: W: spelling-error %description -l en_US > ascii -> ASCII > I guess that's true. It is probably not a good idea to change AsciiBinder and AsciiDoc into upper case ... > rubygem-ascii_binder-doc.noarch: E: version-control-internal-file > /usr/share/gems/gems/ascii_binder-0.1.14/features/support/test_distro/. > gitignore > rubygem-ascii_binder-doc.noarch: W: hidden-file-or-dir > /usr/share/gems/gems/ascii_binder-0.1.14/features/support/test_distro/ > _javascripts/.gitkeep > rubygem-ascii_binder-doc.noarch: E: zero-length > /usr/share/gems/gems/ascii_binder-0.1.14/features/support/test_distro/ > _javascripts/.gitkeep > Indeed, those could be dropped but meh. Hmm, not sure about these. I could drop them, but I think they are part of test project and they corresponds to the similar files in templates directory. I'll rather keep them. > Package is APPROVED. Thx for the review and approval. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
