https://bugzilla.redhat.com/show_bug.cgi?id=1526056 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zbyszek@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review+ --- Comment #7 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- > # Fix shebang. > sed -i 's|/usr/bin/env ruby|/usr/bin/ruby|' %{buildroot}%{gem_instdir}/bin/asciibinder This might not be necessary with the recent shebang rewriting that has been turned on in rawhide. Still needed in lower releases... > git config --global user.email "you@xxxxxxxxxxx" > git config --global user.name "Your Name" Is this necessary? + package name is OK + license is acceptable for Fedora (MIT) + license is specified correctly + builds and installs OK + the binary seems to run OK + Provides/Requires/BR look OK + Packaging:Ruby is followed + fedora-review and rpmlint don't show any important errors rubygem-ascii_binder-doc.noarch: W: spelling-error Summary(en_US) ascii -> ASCII rubygem-ascii_binder-doc.noarch: W: spelling-error %description -l en_US ascii -> ASCII I guess that's true. rubygem-ascii_binder-doc.noarch: W: invalid-url URL: http://asciibinder.org/ <urlopen error [Errno -2] Name or service not known> Works fine. rubygem-ascii_binder-doc.noarch: E: version-control-internal-file /usr/share/gems/gems/ascii_binder-0.1.14/features/support/test_distro/.gitignore rubygem-ascii_binder-doc.noarch: W: hidden-file-or-dir /usr/share/gems/gems/ascii_binder-0.1.14/features/support/test_distro/_javascripts/.gitkeep rubygem-ascii_binder-doc.noarch: E: zero-length /usr/share/gems/gems/ascii_binder-0.1.14/features/support/test_distro/_javascripts/.gitkeep Indeed, those could be dropped but meh. rubygem-ascii_binder.noarch: W: no-documentation rubygem-ascii_binder.noarch: W: no-manual-page-for-binary asciibinder 2 packages and 0 specfiles checked; 4 errors, 8 warnings. Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
