https://bugzilla.redhat.com/show_bug.cgi?id=1481630 --- Comment #54 from Nicolas Chauvet (kwizart) <kwizart@xxxxxxxxx> --- There is nothing holding review maybe exept that the 4.16-rc1 kernel lands (or maybe even before rc1). Does it have everything needed ? I plan to do some runtime tests once everything has landed in the coming weeks. Once this guest addition package will be created, I think it will be updated along the rpmfusion VirtualBox-guest-addition package. As I expect, this last will be disabled for f28+, but continue to exist for older fedora,rhel. Based on this I think it's indeed correct to have the obsoletes/provide to use a version macro. So everything is fine (maybe only to have a comment to schedule the removal of obsoletes/provides for f28+2 or whatever rhel version is relevant). One item I wonder if it can be improved is the "vboxsf" user/group creation: (which I think is the correct way to have this user/group created). But: Is this really needed ? Can this be avoided in the long run so vbox graphical users don't need to add themselves to this group manually ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
