https://bugzilla.redhat.com/show_bug.cgi?id=1531955 --- Comment #16 from Alec Leamas <leamas.alec@xxxxxxxxx> --- (In reply to Antonio Trande from comment #15) > > All LICENSE files are already included: > > ## Renamed each single license file > cp -p apps/rep_sep/LICENSE LGPLv3+.txt > cp -p apps/rabema/LICENSE GPLv3+.txt > cp -p LICENSE BSD.txt Not really. I see: $ cd BUILD $ find . -name LICENSE\* | wc -l 39 So, here is at least 39 license files. Looking at size, many are unique: ls -l $(find . -iname LICENSE\* ) | awk '{print $5}' | sort | uniq | wc -l 30 > They're different licenses with same file name, here why i chose to rename > them. There is not problem in my opinion. GL at https://fedoraproject.org/wiki/Packaging:LicensingGuidelines says: "If the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %license." I see no exceptions here. All of them should go into %license, >= 40 files. > 'plot.awk' and 'ps2pswLinks.gawk' are used as input files by other seqan > scripts; see 'roi_plot_9.sh' script. > > To be used, 'roi_plot_9.sh' needs them inside /usr/bin. That still doesn't make them to binaries, for sure. They should be 444, and such files does not belong in /usr/bin. I think I'd move them to /usr/share/seqan2 and either patch the scripts using them or add a symlink to /usr/bin (a symlink is OK). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
