[Bug 1508950] Review Request: eccodes - a library for decoding and encoding WMO data formats

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1508950



--- Comment #6 from Jos de Kloe <josdekloe@xxxxxxxxx> ---
Spec URL: http://www.jdekloe.nl/Fedora/eccodes-2.6.0-1-rev1/eccodes.spec
SRPM URL:
http://www.jdekloe.nl/Fedora/eccodes-2.6.0-1-rev1/eccodes-2.6.0-1.fc26.src.rpm

Thanks a lot for your comments.
The above links point to my next iteration.
Changes this time are:
* update to new upstream version 2.6.0
* defined a downstream so version since upstream refuses to do so
* found that next to LD_LIBRARY_PATH the tests also need the LIBRARY_PATH
environment setting, since many tests generate c or fortran code and compile it
on the fly. Without it the compiler does not find the libraries in the build
tree. With this change the rpath setting could be removed from the eccodes.pc
and eccodes_f90.pc without the earlier mentioned problems
* added a small patch to fix 2 remaining failures for tests that compile pieces
of fortran code

With these changes the number of errors reported by rpmlint is reduced to 5.
Four of the remaining errors are false positives since they are triggered by
data files that start with something resembling a shebang as mentioned above.

The only other error is:
   eccodes-debuginfo.x86_64: E: useless-provides debuginfo(build-id)
I suspect this is caused by the fact that the package installs two tools in the
bin directory that are binary identical to each other. I don't think I can fix
that, since it is an upstream choice to do it like that.

I noticed two new warnings on the so files that I don't understand yet:
eccodes.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libeccodes.so
eccodes.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libeccodes_f90.so
this seems not correct to me.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux