https://bugzilla.redhat.com/show_bug.cgi?id=1520581 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> --- Url and Source0 addresses are Ok. Source archive (SHA-256: 55db4520617d859d88c0ee54965da815b7226d792b8cdc8debf92073559e0463) is original. Ok. Summary verified from lib/Authen/Passphrase.pm. Ok. TODO: The Description text is about Authen::Passphrase module only while the perl-Authen-Passphrase package provides all the modules included in the Authen-Passphrase CPAN distribition. I recommend to change the Description text so that it's more representative. E.g.: These Perl modules provide a passphrase recognizer. Its job is to recognize whether an offered passphrase is the right one. Various passphrase encoding schemes are supported. License verified from lib/Authen/Passphrase, README, and other files. Ok. No XS code, noarch BuildArch is Ok. Build-time requires are Ok. All tests pass. Ok. $ rpmlint perl-Authen-Passphrase.spec ../SRPMS/perl-Authen-Passphrase-0.008-1.fc28.src.rpm ../RPMS/noarch/perl-Authen-Passphrase-0.008-1.fc28.noarch.rpm perl-Authen-Passphrase.src: W: spelling-error Summary(en_US) passphrases -> pass phrases, pass-phrases, paraphrases perl-Authen-Passphrase.src: W: spelling-error %description -l en_US passphrases -> pass phrases, pass-phrases, paraphrases perl-Authen-Passphrase.src: W: spelling-error %description -l en_US recogniser -> recognizer, recognize perl-Authen-Passphrase.src: W: spelling-error %description -l en_US recognise -> recognize, recognition perl-Authen-Passphrase.src: W: spelling-error %description -l en_US recognisers -> recognizes perl-Authen-Passphrase.noarch: W: spelling-error Summary(en_US) passphrases -> pass phrases, pass-phrases, paraphrases perl-Authen-Passphrase.noarch: W: spelling-error %description -l en_US passphrases -> pass phrases, pass-phrases, paraphrases perl-Authen-Passphrase.noarch: W: spelling-error %description -l en_US recogniser -> recognizer, recognize perl-Authen-Passphrase.noarch: W: spelling-error %description -l en_US recognise -> recognize, recognition perl-Authen-Passphrase.noarch: W: spelling-error %description -l en_US recognisers -> recognizes 2 packages and 1 specfiles checked; 0 errors, 10 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Authen-Passphrase-0.008-1.fc28.noarch.rpm drwxr-xr-x 2 root root 0 Jan 3 17:25 /usr/share/doc/perl-Authen-Passphrase -rw-r--r-- 1 root root 8780 Feb 4 2012 /usr/share/doc/perl-Authen-Passphrase/Changes -rw-r--r-- 1 root root 1411 Feb 4 2012 /usr/share/doc/perl-Authen-Passphrase/README -rw-r--r-- 1 root root 7314 Jan 3 17:25 /usr/share/man/man3/Authen::Passphrase.3pm.gz -rw-r--r-- 1 root root 2771 Jan 3 17:25 /usr/share/man/man3/Authen::Passphrase::AcceptAll.3pm.gz -rw-r--r-- 1 root root 3718 Jan 3 17:25 /usr/share/man/man3/Authen::Passphrase::BigCrypt.3pm.gz -rw-r--r-- 1 root root 4642 Jan 3 17:25 /usr/share/man/man3/Authen::Passphrase::BlowfishCrypt.3pm.gz -rw-r--r-- 1 root root 2674 Jan 3 17:25 /usr/share/man/man3/Authen::Passphrase::Clear.3pm.gz -rw-r--r-- 1 root root 3676 Jan 3 17:25 /usr/share/man/man3/Authen::Passphrase::Crypt16.3pm.gz -rw-r--r-- 1 root root 5134 Jan 3 17:25 /usr/share/man/man3/Authen::Passphrase::DESCrypt.3pm.gz -rw-r--r-- 1 root root 3068 Jan 3 17:25 /usr/share/man/man3/Authen::Passphrase::EggdropBlowfish.3pm.gz -rw-r--r-- 1 root root 3282 Jan 3 17:25 /usr/share/man/man3/Authen::Passphrase::LANManager.3pm.gz -rw-r--r-- 1 root root 3305 Jan 3 17:25 /usr/share/man/man3/Authen::Passphrase::LANManagerHalf.3pm.gz -rw-r--r-- 1 root root 4133 Jan 3 17:25 /usr/share/man/man3/Authen::Passphrase::MD5Crypt.3pm.gz -rw-r--r-- 1 root root 2894 Jan 3 17:25 /usr/share/man/man3/Authen::Passphrase::MySQL323.3pm.gz -rw-r--r-- 1 root root 2841 Jan 3 17:25 /usr/share/man/man3/Authen::Passphrase::MySQL41.3pm.gz -rw-r--r-- 1 root root 3168 Jan 3 17:25 /usr/share/man/man3/Authen::Passphrase::NTHash.3pm.gz -rw-r--r-- 1 root root 3288 Jan 3 17:25 /usr/share/man/man3/Authen::Passphrase::NetscapeMail.3pm.gz -rw-r--r-- 1 root root 3752 Jan 3 17:25 /usr/share/man/man3/Authen::Passphrase::PHPass.3pm.gz -rw-r--r-- 1 root root 2758 Jan 3 17:25 /usr/share/man/man3/Authen::Passphrase::RejectAll.3pm.gz -rw-r--r-- 1 root root 4561 Jan 3 17:25 /usr/share/man/man3/Authen::Passphrase::SaltedDigest.3pm.gz -rw-r--r-- 1 root root 4472 Jan 3 17:25 /usr/share/man/man3/Authen::Passphrase::VMSPurdy.3pm.gz drwxr-xr-x 2 root root 0 Jan 3 17:25 /usr/share/perl5/vendor_perl/Authen drwxr-xr-x 2 root root 0 Jan 3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase -rw-r--r-- 1 root root 18283 Jan 3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase.pm -rw-r--r-- 1 root root 2743 Jan 3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase/AcceptAll.pm -rw-r--r-- 1 root root 7874 Jan 3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase/BigCrypt.pm -rw-r--r-- 1 root root 10517 Jan 3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase/BlowfishCrypt.pm -rw-r--r-- 1 root root 2717 Jan 3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase/Clear.pm -rw-r--r-- 1 root root 7850 Jan 3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase/Crypt16.pm -rw-r--r-- 1 root root 14666 Jan 3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase/DESCrypt.pm -rw-r--r-- 1 root root 5187 Jan 3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase/EggdropBlowfish.pm -rw-r--r-- 1 root root 6158 Jan 3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase/LANManager.pm -rw-r--r-- 1 root root 5946 Jan 3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase/LANManagerHalf.pm -rw-r--r-- 1 root root 8236 Jan 3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase/MD5Crypt.pm -rw-r--r-- 1 root root 3944 Jan 3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase/MySQL323.pm -rw-r--r-- 1 root root 3795 Jan 3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase/MySQL41.pm -rw-r--r-- 1 root root 5695 Jan 3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase/NTHash.pm -rw-r--r-- 1 root root 6085 Jan 3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase/NetscapeMail.pm -rw-r--r-- 1 root root 9808 Jan 3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase/PHPass.pm -rw-r--r-- 1 root root 2769 Jan 3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase/RejectAll.pm -rw-r--r-- 1 root root 12257 Jan 3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase/SaltedDigest.pm -rw-r--r-- 1 root root 10930 Jan 3 17:25 /usr/share/perl5/vendor_perl/Authen/Passphrase/VMSPurdy.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Authen-Passphrase-0.008-1.fc28.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.26.1) 1 perl(Authen::DecHpwd) >= 2.003 1 perl(Authen::Passphrase) >= 0.003 1 perl(Authen::Passphrase::DESCrypt) 1 perl(Authen::Passphrase::LANManagerHalf) 1 perl(Carp) 1 perl(Crypt::DES) 1 perl(Crypt::Eksblowfish::Bcrypt) >= 0.008 1 perl(Crypt::Eksblowfish::Uklblowfish) >= 0.008 1 perl(Crypt::MySQL) >= 0.03 1 perl(Crypt::PasswdMD5) >= 1.0 1 perl(Crypt::UnixCrypt_XS) >= 0.08 1 perl(Data::Entropy::Algorithms) >= 0.000 1 perl(Digest) >= 1.00 1 perl(Digest::MD4) >= 1.2 1 perl(Digest::MD5) >= 1.99 1 perl(Digest::SHA) 1 perl(MIME::Base64) >= 2.21 1 perl(Module::Runtime) >= 0.011 1 perl(Params::Classify) >= 0.000 1 perl(parent) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Authen-Passphrase-0.008-1.fc28.noarch.rpm | sort -f | uniq -c 1 perl(Authen::Passphrase) = 0.008 1 perl(Authen::Passphrase::AcceptAll) = 0.008 1 perl(Authen::Passphrase::BigCrypt) = 0.008 1 perl(Authen::Passphrase::BlowfishCrypt) = 0.008 1 perl(Authen::Passphrase::Clear) = 0.008 1 perl(Authen::Passphrase::Crypt16) = 0.008 1 perl(Authen::Passphrase::DESCrypt) = 0.008 1 perl(Authen::Passphrase::EggdropBlowfish) = 0.008 1 perl(Authen::Passphrase::LANManager) = 0.008 1 perl(Authen::Passphrase::LANManagerHalf) = 0.008 1 perl(Authen::Passphrase::MD5Crypt) = 0.008 1 perl(Authen::Passphrase::MySQL323) = 0.008 1 perl(Authen::Passphrase::MySQL41) = 0.008 1 perl(Authen::Passphrase::NetscapeMail) = 0.008 1 perl(Authen::Passphrase::NTHash) = 0.008 1 perl(Authen::Passphrase::PHPass) = 0.008 1 perl(Authen::Passphrase::RejectAll) = 0.008 1 perl(Authen::Passphrase::SaltedDigest) = 0.008 1 perl(Authen::Passphrase::VMSPurdy) = 0.008 1 perl-Authen-Passphrase = 0.008-1.fc28 Binary provides are Ok. Package builds in in F28 (https://koji.fedoraproject.org/koji/taskinfo?taskID=23984147). Ok. Otherwise the package is in line with Fedora and Perl packaging guide lines. Please consider fixing the `TODO' item before building this package. Resolution: Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
