https://bugzilla.redhat.com/show_bug.cgi?id=1529167 --- Comment #4 from Björn "besser82" Esser <besser82@xxxxxxxxxxxxxxxxx> --- (In reply to Carl George from comment #3) > > You shoudn't greedy-glob there, since you might own the `__pycache__` directory > > I don't necessarily disagree, but I duplicated that part from the example > spec file in the guidelines. How do we go about getting the guidelines > updated? > > https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file Well, the guidelines were written in times before Python 3.4 (or 3.3?), which introduced the `__pycache__` dir… We can try to get them updated, but FPC seems to be pretty unresponsive in the last time… If I find the time during the naxt days, I'll write a proposal for that. > > Please fix `%{undefined rhel}` ---> `%{!?rhel}` during import! > > What is the issue here? The undefined macro exists to make that type of > condition more readable. It's built into RPM (defined in > /usr/lib/rpm/macros) and exists as far back as RHEL 5 (perhaps even further). Ohh… I didn't know that existed. I've said nothing then. ;) > I'll be happy to review your packages, but it might have to wait until next > week unless I can find some time this afternoon. Yay! =) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
