[Bug 1529167] Review Request: python-parso - Parser that supports error recovery and round-trip parsing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1529167



--- Comment #3 from Carl George <carl@george.computer> ---
> You shoudn't greedy-glob there, since you might own the `__pycache__` directory

I don't necessarily disagree, but I duplicated that part from the example spec
file in the guidelines.  How do we go about getting the guidelines updated?

https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file

> Please fix `%{undefined rhel}` ---> `%{!?rhel}` during import!

What is the issue here?  The undefined macro exists to make that type of
condition more readable.  It's built into RPM (defined in /usr/lib/rpm/macros)
and exists as far back as RHEL 5 (perhaps even further).

I'll be happy to review your packages, but it might have to wait until next
week unless I can find some time this afternoon.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux