https://bugzilla.redhat.com/show_bug.cgi?id=1520584 Peter Oliver <mavit@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mavit@xxxxxxxxxxxx Flags| |fedora-review+ --- Comment #2 from Peter Oliver <mavit@xxxxxxxxxxxx> --- The packaging guidelines say that you SHOULD ask upstream to include the text of the licences in its own file. Also, it would be better to use https:// rather than http:// for Source0. Other than that, it all looks good to me. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 7 files have unknown license. Detailed output of licensecheck in /home/mavit/src/fedora/1520584-perl-MooseX- Types-NetAddr-IP/licensecheck.txt [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [-]: Package does not own files or directories owned by other packages. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [x]: Package contains the mandatory BuildRequires and Requires:. [x]: CPAN urls should be non-versioned. ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. Didn’t try, but tests passed. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. Didn’t test, but matrix.cpantesters.org/?dist=MooseX-Types-NetAddr-IP+0.07 looks favourable. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: perl-MooseX-Types-NetAddr-IP-0.07-1.fc28.noarch.rpm perl-MooseX-Types-NetAddr-IP-0.07-1.fc28.src.rpm perl-MooseX-Types-NetAddr-IP.noarch: W: spelling-error Summary(en_US) coercions -> coercion, coercion's, coercion s perl-MooseX-Types-NetAddr-IP.src: W: spelling-error Summary(en_US) coercions -> coercion, coercion's, coercion s 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory perl-MooseX-Types-NetAddr-IP.noarch: W: spelling-error Summary(en_US) coercions -> coercion, coercion's, coercion s perl-MooseX-Types-NetAddr-IP.noarch: W: invalid-url URL: http://search.cpan.org/dist/MooseX-Types-NetAddr-IP/ <urlopen error [Errno -2] Name or service not known> 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Requires -------- perl-MooseX-Types-NetAddr-IP (rpmlib, GLIBC filtered): perl(:MODULE_COMPAT_5.26.1) perl(Module::Runtime) perl(MooseX::Types) perl(MooseX::Types::Moose) perl(namespace::clean) perl(strict) perl(warnings) Provides -------- perl-MooseX-Types-NetAddr-IP: perl(MooseX::Types::NetAddr::IP) perl-MooseX-Types-NetAddr-IP Source checksums ---------------- http://www.cpan.org/authors/id/T/TC/TCAINE/MooseX-Types-NetAddr-IP-0.07.tar.gz : CHECKSUM(SHA256) this package : 4df5a5d1ce8346dd1f92c0f0bc38ac7383a1b2dd8977fa9e708340e72e027a88 CHECKSUM(SHA256) upstream package : 4df5a5d1ce8346dd1f92c0f0bc38ac7383a1b2dd8977fa9e708340e72e027a88 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1520584 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Perl Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
