https://bugzilla.redhat.com/show_bug.cgi?id=1513733 --- Comment #5 from Christoph Junghans <junghans@xxxxxxxxx> --- Thanks for the review! (In reply to Ankur Sinha (FranciscoD) from comment #4) > Mostly good, a few minor issues: > > - the build logs show errors about `dot` not being available while doc > generation. You should include it in the BR and re-build to check that docs > are built correctly. Good catch, thanks, fixed. > - Please use arch-specific requires. Fixed. > - ldconfig must be run for packages with shared libraries: > https://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries Not needed for mpi-only packages (see #559009), I also added a comment to the spec files: # MPI subpackages don't need the ldconfig magic. They are hidden by # default, in MPI back-end-specific directory, and only show to the # user after the relevant environment module has been loaded. # rpmlint will report that as errors, but it is fine. Spec URL: https://junghans.fedorapeople.org/libcircle.spec SRPM URL: https://junghans.fedorapeople.org/libcircle-0.2.1-0.3rc1.fc27.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
