[Bug 1508950] Review Request: eccodes - a library for decoding and encoding WMO data formats

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1508950



--- Comment #3 from Jos de Kloe <josdekloe@xxxxxxxxx> ---
Spec URL: http://www.jdekloe.nl/Fedora/eccodes-2.5.0-1-rev2/eccodes.spec
SRPM URL:
http://www.jdekloe.nl/Fedora/eccodes-2.5.0-1-rev2/eccodes-2.5.0-1.fc26.src.rpm

Here is my next try.
I am not happy yet, but there is some improvement.
* Obsoletes / Provides have been disabled
* post / postun sections have been added
* LD_LIBRARY_PATH env setting has been added to the ctest command. This is
needed to let the tests run

Still rpmlint issues a number of errors and warnings:
   7 packages and 0 specfiles checked; 8 errors, 57 warnings.

eccodes.x86_64: E: invalid-soname /usr/lib64/libeccodes.so libeccodes.so

has been reported upstream. Not clear yet what they will do.
See: https://software.ecmwf.int/issues/browse/SUP-1809
[this issue has been made public now]

eccodes.x86_64: E: wrong-script-interpreter
and
eccodes.x86_64: E: non-executable-script
for files:
  /usr/share/eccodes/definitions/grib1/local.82.0.def
  /usr/share/eccodes/definitions/grib1/local.82.83.def

these are a false errors. These def files are data files, not scripts.
They start by accident with a shebang like line due to a funny choice of data
format by upstream.

eccodes-devel.x86_64: E: rpath-in-buildconfig 
  /usr/lib64/pkgconfig/eccodes.pc
  /usr/lib64/pkgconfig/eccodes_f90.pc

Sure, these files contain rpath settings.
However, removing these settings totally cripples the test system.
I don't know what to do here. Any idea how to solve this?

eccodes-debuginfo.x86_64: E: useless-provides debuginfo(build-id)

I don't know what this means. How to solve it?

The warnings are mostly on missing man pages (44 times).
and false warnings on spelling errors (7 times)

An issue requesting addition of the missing man pages was opened here:
https://software.ecmwf.int/issues/browse/SUP-2271
[this issue is still internal, but I requested them to make it public]

The other warnings are:

eccodes-devel.x86_64: W: only-non-binary-in-usr-lib

this is a bug in rpmlint I think.
/usr/lib64 contains 2 fortran *.mod files which are needed
to be able to compile fortran code with this library.
These files are possibly ascii, but they are generated by the compiler
and surely should be in the devel package.

eccodes-devel.x86_64: W: no-documentation
python2-eccodes.x86_64: W: no-documentation
eccodes-debugsource.x86_64: W: no-documentation

all relevant documentation is included in the main package, so no problem here.

eccodes.x86_64: W: shared-lib-calls-exit /usr/lib64/libeccodes.so
exit@GLIBC_2.2.5
eccodes.x86_64: W: shared-lib-calls-exit /usr/lib64/libeccodes_f90.so
exit@GLIBC_2.2.5

this is a proper problem.
It is reported upstream here: https://software.ecmwf.int/issues/browse/SUP-2272
[this issue is still internal, but I requested them to make it public]

Also the 4 failing tests are still excluded in the check section.
I tried hard but could not yet find a way to make them pass.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux