https://bugzilla.redhat.com/show_bug.cgi?id=1517102 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires FIX: Please add constrain to perl(Module::Build::Tiny) >= 0.034 FIX: Please add following buildrequires: - perl(bignum) - lib/Test/Mock/Time.pm - perl(Carp) - lib/Test/Mock/Time.pm - perl(constant) - lib/Test/Mock/Time.pm - perl(strict) - Build.PL:2 - perl(Time::HiRes) - t/Time::HiRes.t - perl(utf8) - lib/Test/Mock/Time.pm - perl(warnings) - Build.PL:3 - uncomment BR perl(Export::Attrs) TODO: If you want to run some optional tests, please add also - perl(AnyEvent) - perl(EV) - perl(Mojolicious) >= 6 - perl(Mojo::IOLoop) $ rpm -qp --requires perl-Test-Mock-Time-0.1.6-1.fc28.noarch.rpm | sort | uniq -c 1 perl(bignum) 1 perl(Carp) 1 perl(constant) 1 perl(Export::Attrs) 1 perl(List::Util) 1 perl(:MODULE_COMPAT_5.26.1) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(Test::MockModule) 1 perl(utf8) 1 perl(:VERSION) >= 5.10.1 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -qp --provides perl-Test-Mock-Time-0.1.6-1.fc28.noarch.rpm | sort | uniq -c 1 perl(Test::Mock::Time) = 0.1.6 1 perl-Test-Mock-Time = 0.1.6-1.fc28 Binary provides are Ok. $ rpmlint ./perl-Test-Mock-Time* perl-Test-Mock-Time.noarch: W: spelling-error %description -l en_US HiRes -> Hires, Hines, Hies perl-Test-Mock-Time.src: W: spelling-error %description -l en_US HiRes -> Hires, Hines, Hies 2 packages and 1 specfiles checked; 0 errors, 2 warnings. Rpmlint is ok FIX: Please move LICENSE from %docs to %license. Please correct all 'FIX' issues and consider fixing 'TODO' items. Otherwise, the package looks good. Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
