https://bugzilla.redhat.com/show_bug.cgi?id=1517000 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |vondruch@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |vondruch@xxxxxxxxxx Flags| |fedora-review? --- Comment #1 from Vít Ondruch <vondruch@xxxxxxxxxx> --- Taking for a review. * Patch filename and URL - I would name the patch by some more explanatory name, e.g.: rubygem-notiffany-0.1.1-Fix-uninitialized-constant-Notiffany-VERSION-test-failure.patch - I prefer to use the URL, which gives me more context, e.g. https://github.com/guard/notiffany/pull/31 From the URL you provided, I can see the patch, but I can't see the associated discussion. Otherwise the package looks good. Please fix the nit above and I'll approve the package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
