Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: compat-expat1 - library compat package for expat 1.x https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=251361 ------- Additional Comments From jorton@xxxxxxxxxx 2007-08-22 04:59 EST ------- Thanks for the review! (In reply to comment #6) > 1. Does this package need %makeinstall? Yes, the Makefile doesn't support DESTDIR. > 2. The URL in the Source line looks wrong... Fixed in -3 at above location. > 3. By no means a blocker, but there's no dist tag. This is by intent, I see no need to use the dist tag on the devel branch for any package. (particularly so for a package like this, as you say, which will never exist in any branch) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review