Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: compat-expat1 - library compat package for expat 1.x https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=251361 ------- Additional Comments From kevin@xxxxxxxxx 2007-08-22 01:14 EST ------- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (MIT) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: aff487543845a82fe262e6e2922b4c8e expat-1.95.8.tar.gz aff487543845a82fe262e6e2922b4c8e expat-1.95.8.tar.gz.1 OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Spec has needed ldconfig in post and postun OK - .la files are removed. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs See below - Should have dist tag Issues: 1. Does this package need %makeinstall? You shouldn't use it if you can avoid it. See: http://fedoraproject.org/wiki/PackagingDrafts/MakeInstall 2. The URL in the Source line looks wrong... http://download.sourceforge.net/expat/expat-%{version}.tar.gz should be http://downloads.sourceforge.net/expat/expat-%{version}.tar.gz (note the plural). 3. By no means a blocker, but there's no dist tag. Since this is a compat package and hopefully won't be around for a long time it's probibly fine not to bother with one. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review