[Bug 1508950] Review Request: eccodes - a library for decoding and encoding WMO data formats

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1508950



--- Comment #1 from Michael Schwendt <bugs.michael@xxxxxxx> ---
> Obsoletes:  grib_api-devel < 1.18.0-3
> Provides:   grib_api-devel = 1.18.0-3
> Provides:   grib_api-devel%{?_isa} = 1.18.0-3

Questionable. And deserving a comment in the spec file at least.

First of all, grib_api is way above 1.18.0 already, so one would like to know
whether this package really _replaces_ all of that. 

Secondly, if replacing a package, while the Obsoletes tag is correct and
needed, one must be careful about whether/when to add the Provides tag. Only if
the new package is compatible enough as a replacement, adding the Provides tag
makes sense. Only then something that BuildRequires grib_api-devel would work
if eccodes-devel is pulled in as the replacement package. That's mentioned
here:
 
https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages
Since basic files, such as the pkg-config files, have been renamed, the
replacement package is _not_ compatible enough.


> %{_libdir}/*.so*

https://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux