https://bugzilla.redhat.com/show_bug.cgi?id=1503175 Aivar Annamaa <aivar.annamaa@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(aivar.annamaa@gma | |il.com) | --- Comment #10 from Aivar Annamaa <aivar.annamaa@xxxxxxxxx> --- Thanks, Miro! I got rid of pypi_name, the -n option, extra slahs after buildroot (the slash after %{_datadir} is required, right?). I also introduced desktop-file-install. I also updated the version in changelog (forgot it last time). With `%{python3_sitelib}/thonny` rpmbuild gave me: Checking for unpackaged file(s): /usr/lib/rpm/check-files /home/aivar/rpmbuild/BUILDROOT/thonny-2.1.15-1.fc26.x86_64 error: Installed (but unpackaged) file(s) found: /usr/lib/python3.6/site-packages/thonny-2.1.15-py3.6.egg-info/PKG-INFO /usr/lib/python3.6/site-packages/thonny-2.1.15-py3.6.egg-info/SOURCES.txt /usr/lib/python3.6/site-packages/thonny-2.1.15-py3.6.egg-info/dependency_links.txt /usr/lib/python3.6/site-packages/thonny-2.1.15-py3.6.egg-info/entry_points.txt /usr/lib/python3.6/site-packages/thonny-2.1.15-py3.6.egg-info/requires.txt /usr/lib/python3.6/site-packages/thonny-2.1.15-py3.6.egg-info/top_level.txt I tried `%{python3_sitelib}/thonny*` instead, and it seemed to work fine. Should I keep this? The changes are visible here: https://bitbucket.org/plas/thonny-rpm/commits/8e6565e3b387cde2402f296ea2f11d303582a724 I now noticed that I've forgotten a licensing issue. The toolbar icons are licensed with EPL, so I guess I need to change `License: MIT` to `License: MIT and EPL`. Am I right? But what should I then do with the EPL license text? (It is included in the upstream tarball in LICENSES/ECLIPSE-ICONS-LICENSE.txt) Currently my `%license LICENSE.txt` references the MIT license, which is the license for the code. I didn't find clear answers from https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#Multiple_Licensing_Scenarios -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
