https://bugzilla.redhat.com/show_bug.cgi?id=1503175 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mhroncok@xxxxxxxxxx Flags| |needinfo?(aivar.annamaa@gma | |il.com) --- Comment #9 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- I can do a full review and I'm also willing to sponsor you. I would very much like to include Thonny in the Fedora Python Classroom Lab. >From reading the spec, couple of nitpicks: * The reason to define and use the pypi_name macro does not apply here, since it equals the package name. I'd recommend getting rid of it and use %{name} everywhere. * I believe the -n option for %autosetup is not necessary, the used value is the default. * %{buildroot} already contains the trailing slash, so using %{buildroot}/ is not necessary and may eventually lead to trouble. * You can use desktop-file-install instead of install + desktop-file-validate. * Using %{python3_sitelib}/* in the %files section is very error prone. Instead, I recommend to go with something more specific, like %{python3_sitelib}/thonny (I haven't yet seen what the package installs exactly, so this might differ a bit, but a quick look at setup.py makes me think it should work here). * If more icon/logo resolutions are available, it would be a good idea to package them as well. (At least the ico file seems to have more resolution options). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
