https://bugzilla.redhat.com/show_bug.cgi?id=1508384 Stefan Hajnoczi <stefanha@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR) --- Comment #2 from Stefan Hajnoczi <stefanha@xxxxxxxxxx> --- (In reply to Igor Gnatenko from comment #1) > * Give links to RAW text, not to html ones.. > https://raw.githubusercontent.com/stefanha/git-publish/master/git-publish. > spec > > > %build > is not needed > > > Requires: python2 >= 2.7 > is not needed > > * YOu should patch shebang to be /usr/bin/python3 > * Because /usr/bin/env is wrong > * And because python3 is the right interpreter unless there is good reason > to keep it py2 > > > Source0: https://github.com/stefanha/git-publish/archive/v%{version}.tar.gz#/%{name}-%{version}.tar.gz > Source0: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz > > --- > > Apart from this, package looks good. Did you send introduction to > devel@xxxxxxxxxxxxxxxxxxxxxxx ? Thanks for your feedback, Igor. I will address them and post an update. Will send an introduction to devel@xxxxxxxxxxxxxxxxxxxxxxx too. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
