[Bug 1508384] Review Request: git-publish - Prepare and store patch revisions as git tags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1508384



--- Comment #1 from Igor Gnatenko <ignatenko@xxxxxxxxxx> ---
* Give links to RAW text, not to html ones..
https://raw.githubusercontent.com/stefanha/git-publish/master/git-publish.spec

> %build
is not needed

> Requires:       python2 >= 2.7
is not needed

* YOu should patch shebang to be /usr/bin/python3
  * Because /usr/bin/env is wrong
  * And because python3 is the right interpreter unless there is good reason to
keep it py2

> Source0:        https://github.com/stefanha/git-publish/archive/v%{version}.tar.gz#/%{name}-%{version}.tar.gz
Source0:        %{url}/archive/v%{version}/%{name}-%{version}.tar.gz

---

Apart from this, package looks good. Did you send introduction to
devel@xxxxxxxxxxxxxxxxxxxxxxx ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux