Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: twill - A simple scripting language for Web browsing https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=253355 ------- Additional Comments From opensource@xxxxxxxxx 2007-08-18 05:28 EST ------- - The Group-tag is wrong: Group: TODO - iirc is python no longer in the default build eviroment, so this package should not build in devel koji. Afaik you need to add "python-devel" to BuildRequires. - Imho you should remove this defination, because they are not used in the spec: %{!?python_sitearch: %define python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib(1)")} - This should be imho ended with a "/" to show, that it is directory, also it is not working, %{python_sitelib}/%{name}-%{version}-py%{pyver}.egg-info so it should be: %{python_sitelib}/%{name}-%{version}%{beta_ver}-py%{pyver}.egg-info/ (the %{beta_ver} was missing) - The license, which is in docs/LICENSE.txt in the tarball is not packaged. - Also the everything else in docs/ is not packaged but may be useful, e.g. ChangeLog and all the .txt files, and the example in advocacy. - The Requires seem not to be sufficient, too. E.g. it seems that pyhon-mechanize should be required and imho python does not need to be in Requires. - The buildarch should be noarch: BuildArch: noarch -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review