https://bugzilla.redhat.com/show_bug.cgi?id=879928 --- Comment #17 from Pavel Alexeev <pahan@xxxxxxxxxxxxx> --- Hello Robert-André Mauchin. Thank you for the taking care on it. > - Use this simplified Source: > Source0: https://github.com/RigsOfRods/rigs-of-rods/archive/%{version}/%{name}-%{version}.tar.gz Done > - COPYING should not be listed in %doc, but in %licensi: > %files > %doc AUTHORS.md BUILDING.md CONTRIBUTING.md DEPENDENCIES.md README.md > %license COPYING Done > - There are several files with license other than GPLv3: > *No copyright* BSL > ------------------ > rigs-of-rods-0.4.7.0/source/main/utils/utf8/README.md > *No copyright* CC by (v2.5) > --------------------------- > rigs-of-rods-0.4.7.0/bin/resources/famicons/readme.txt > Please add them to the License: field and add a comment explaining which license cover which parts. Done > - You should split the data in /usr/share in a -data noarch subpackage: > Large data in /usr/share should live in a noarch subpackage if package is arched. > Note: Arch-ed rpms have a total of 138373120 bytes in /usr/share > rigsofrods-0.4.7.0-1.fc28.x86_64.rpm:138373120 Done > - Several files have an incorrect FSF address in the header. You should patch them with the updated address and notify upstream about it: Upstream informed about that long time ago - https://github.com/RigsOfRods/rigs-of-rods/issues/538 and it noted in changelog. If you do not insist - I do not willing patch that separately from upstream. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=22792831 Changes: https://github.com/Hubbitus/rpm-rigsofrods/commit/f15a8cffc68d8275a4df81b739f8eb9a2422bc6f Spec: https://raw.githubusercontent.com/Hubbitus/rpm-rigsofrods/f15a8cffc68d8275a4df81b739f8eb9a2422bc6f/rigsofrods.spec Srpm: http://rpm.hubbitus.info/Fedora26/rigsofrods/rigsofrods-0.4.7.0-2.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
