https://bugzilla.redhat.com/show_bug.cgi?id=879928 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zebob.m@xxxxxxxxx Flags| |fedora-review? --- Comment #16 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- Hello, - Use this simplified Source: Source0: https://github.com/RigsOfRods/rigs-of-rods/archive/%{version}/%{name}-%{version}.tar.gz - COPYING should not be listed in %doc, but in %licensi: %files %doc AUTHORS.md BUILDING.md CONTRIBUTING.md DEPENDENCIES.md README.md %license COPYING - There are several files with license other than GPLv3: *No copyright* BSL ------------------ rigs-of-rods-0.4.7.0/source/main/utils/utf8/README.md *No copyright* CC by (v2.5) --------------------------- rigs-of-rods-0.4.7.0/bin/resources/famicons/readme.txt Please add them to the License: field and add a comment explaining which license cover which parts. - You should split the data in /usr/share in a -data noarch subpackage: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 138373120 bytes in /usr/share rigsofrods-0.4.7.0-1.fc28.x86_64.rpm:138373120 See: - Several files have an incorrect FSF address in the header. You should patch them with the updated address and notify upstream about it: rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/CfgFileManager.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/CfgFileManager.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/DecalsManager.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/DecalsManager.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Enums.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Enums.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/FFT.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/FFT.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/GPUNormalMapManager.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/GPUNormalMapManager.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/GodRaysManager.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/GodRaysManager.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Help.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Help.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Hydrax.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Hydrax.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Image.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Image.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/MaterialManager.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/MaterialManager.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Mesh.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Mesh.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Module.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Module.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Noise.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Noise.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Perlin.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Perlin.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Prerequisites.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/PressurePoint.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/PressurePoint.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/ProjectedGrid.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/ProjectedGrid.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/RadialGrid.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/RadialGrid.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Real.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Real.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/RttManager.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/RttManager.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/SimpleGrid.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/SimpleGrid.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/TextureManager.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/TextureManager.h rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Wave.cpp rigsofrods-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/rigsofrods-0.4.7.0-1.fc28.x86_64/source/main/gfx/hydrax/Wave.h -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
