https://bugzilla.redhat.com/show_bug.cgi?id=1492084 --- Comment #4 from srakitnican <samuel.rakitnican@xxxxxxxxx> --- (In reply to mgansser@xxxxxxxx from comment #3) > (In reply to srakitnican from comment #1) > > file COPYING is now in the git: > https://git.sesse.net/?p=movit;a=blob_plain;f=COPYING; > hb=13f6483a23b8d34947a0967269ba6ee19d106562 > > hwo should i comment this in the spec file ? I guess it is fine in that case then, but please add your COPYING text file to %license instead to main and data packages, adding it to devel package is unnecessary since it depends on the main package. Leaving a comment explaining why you are adding the license test file. While we are at it, you don't have any dependencies on the data package or vice versa. Does the main package work without it? > make check fails due src/gtest-all.cc is missing, if I'm right. > > + export GTEST_DIR=/usr/include/gtest > + GTEST_DIR=/usr/include/gtest > + make check > g++ -MMD -MP -Wall -O2 -g -pipe -Wall -Werror=format-security > -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong > --param=ssp-buffer-size=4 -grecord-gcc-switches > -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic > -fvisibility-inlines-hidden -I/usr/include/gtest/include -I/usr/include/SDL > -D_GNU_SOURCE=1 -D_REENTRANT -I/usr/include/eigen3 -o > effect_chain_test.o -c effect_chain_test.cpp > make: *** No rule to make target '/usr/include/gtest/src/gtest-all.cc', > needed by 'gtest-all.o'. Stop. > error: Bad exit status from /var/tmp/rpm-tmp.r8UCxK (%check) Yeah it seems broken, it is alright to leave it out. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
