https://bugzilla.redhat.com/show_bug.cgi?id=1492084 --- Comment #3 from mgansser@xxxxxxxx <mgansser@xxxxxxxxx> --- (In reply to srakitnican from comment #1) > There are a couple of issues that needs to be addressed before the package > is approved. > > - You are including COPYING file from outside the sources. Please don't do > that and instead contact upstream about this issue. Fedora Packaging > Guidelines are clear about this: > https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/ > LicensingGuidelines#License_Text file COPYING is now in the git: https://git.sesse.net/?p=movit;a=blob_plain;f=COPYING;hb=13f6483a23b8d34947a0967269ba6ee19d106562 hwo should i comment this in the spec file ? > - License tag seems to not match actual project license, movit appears to be > GPLv2+ will change to GPLv2+ > - Rpmlint warning 'shared-lib-calls-exit' seems a pretty serious one, I am > not > confident it is harmless. We would need a revaluation from either the > author > or an expert. Not sure if this blocks the package submission either. > $ grep -R 'exit(' . > ./demo.cpp: exit(1); > ./demo.cpp: exit(1); > ./demo.cpp: exit(1); > ./util.cpp: exit(1); > ./util.cpp: exit(1); > ./util.cpp: exit(1); > ./util.cpp: exit(1); > ./util.cpp: exit(1); > ./util.cpp: exit(1); > ./effect_chain.cpp: exit(1); > ./config.guess: exit(1); > ./config.guess: exit(0); > ./resource_pool.cpp: exit(1); > ./resource_pool.cpp: exit(1); > ./gtest_sdl_main.cpp: exit(1); > ./gtest_sdl_main.cpp: exit(err); (In reply to srakitnican from comment #2) > From fedora-devel IRC about shared-lib-calls-exit: > [22:38] <ignatenkobrain> srakitnican: no, it's not blocker ok noticed. > - There is a test included in Makefile, although it would be nice to include > it > in %check section, it is not mandatory. make check fails due src/gtest-all.cc is missing, if I'm right. + export GTEST_DIR=/usr/include/gtest + GTEST_DIR=/usr/include/gtest + make check g++ -MMD -MP -Wall -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -fvisibility-inlines-hidden -I/usr/include/gtest/include -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT -I/usr/include/eigen3 -o effect_chain_test.o -c effect_chain_test.cpp make: *** No rule to make target '/usr/include/gtest/src/gtest-all.cc', needed by 'gtest-all.o'. Stop. error: Bad exit status from /var/tmp/rpm-tmp.r8UCxK (%check) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
