[Bug 1491710] Review Request: GLee - GL Easy Extension library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1491710



--- Comment #2 from Lubomir Rintel <lkundrak@xxxxx> ---
(In reply to Robert-André Mauchin from comment #1)
> Hello,
> 
>  - Group: is not used in Fedora. See:
> https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections
> 
>  - Not needed:
> 
> Requires(post):   /sbin/ldconfig
> Requires(postun): /sbin/ldconfig
> 
>  - make %{?_smp_mflags} → %make_build
> 
>  - make install → %make_install
> 
>  - You forgot to bump Release: to 12:
> 
> Release:        12%{?dist}

Thanks. Adjusted everything but the "make install", since "%make_install" is
used for autotools based stuff that uses DESTDIR -- not relevant here.

New package:

SPEC:
http://copr-dist-git.fedorainfracloud.org/cgit/lkundrak/varia/GLee.git/plain/GLee.spec?id=a0fa8bfa3031e4255e4400af9e41527342ff1e71
SRPM:
https://copr-be.cloud.fedoraproject.org/results/lkundrak/varia/fedora-25-x86_64/00602998-GLee/GLee-5.4.0-12.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux