[Bug 1491997] Review Request: opentest4j - Open Test Alliance for the JVM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1491997



--- Comment #2 from Mikolaj Izdebski <mizdebsk@xxxxxxxxxx> ---
Fixed in-place.

(In reply to Michael Simacek from comment #1)
> - Bundled jar/class files should be removed before build
>   Note: Jar files in source (see attachment)
>   See: http://fedoraproject.org/wiki/Packaging:Java#Pre-
>   built_JAR_files_.2F_Other_bundled_software'

gradle-wrapper.jar... Removed.

> - Nitpick: mixed tabs and spaces

Untabified spec.

> - I think you should preserve the manifest entries added by gradle build. At
> least Implementation-* and Specification-*.

Done.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux