[Bug 1246199] Review Request: rdopkg - RPM packaging automation tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1246199



--- Comment #13 from Jakub Ruzicka <jruzicka@xxxxxxxxxx> ---
(In reply to Neal Gompa from comment #12)
> > I wanted to wait until it's supported in latest EL to avoid %if but OK, I'll pave the way ;)
> 
> I'm not sure how it could get supported in EL7, since RPM 4.11 and Yum don't
> support it. We'd be waiting for EL8...
> 
> Just do "%if 0%{?fedora} || 0%{?rhel} >= 8"

I've addressed your suggestions in
https://softwarefactory-project.io/r/#/c/9546/

Please either leave +1/-1 there (you can login with github) or let me know here
if it's OK.

> If there's a missing dependency, I'd rather block rdopkg from being included
> period.

Although missing python3-bunch is being investigated, it is absolutely no
reason to block because rdopkg has on-demand import and the missing dep is only
needed for `rdopkg cbsbuild` command which is CLI and CLI depends on python2
version so it's all good.

I specifically built rdopkg in a way so that one broken subcommand doesn't
block entire project and missing deps only surface for commands that really use
them. Unlike usual python LOAD ALL THE MODULES and then really use 2 of them ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux