[Bug 1487611] Review Request: dontpanic - Very simple library and executable used in testing Alien:: Base

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1487611



--- Comment #5 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
Hello,


There are some obsoletes macros in configure:

[!]: Package should not use obsolete m4 macros
     Note: Some obsoleted macros found, see the attachment.
     See: https://fedorahosted.org/FedoraReview/wiki/AutoTools

AutoTools: Obsoleted m4s found
------------------------------
  AM_PROG_LIBTOOL found in: dontpanic-1.00/configure.ac:15
  AC_PROG_LIBTOOL found in: dontpanic-1.00/configure.ac:14


These need to be patched with LT_INIT. See
https://www.gnu.org/software/libtool/manual/html_node/LT_005fINIT.html for
further details.

Here's a patch:

diff -up dontpanic-1.00/configure.ac.fix_obsolete_m4s
dontpanic-1.00/configure.ac
--- dontpanic-1.00/configure.ac.fix_obsolete_m4s    2016-06-22
21:31:58.000000000 +0200
+++ dontpanic-1.00/configure.ac    2017-09-04 12:35:55.066064941 +0200
@@ -11,8 +11,7 @@ AC_CONFIG_FILES([src/dontpanic.pc])

 # Checks for programs.
 AC_PROG_CC
-AC_PROG_LIBTOOL
-AM_PROG_LIBTOOL
+LT_INIT

 # Checks for libraries.


 - You can replace %setup -q + patchX -p1 with the following macro that will
handle the setup and all the patches automatically:

%prep
%autosetup -p1

 - There's a typo in your comment above your patch: congifured → configured


The good news is I don't get installation errors anymore.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux