[Bug 1481645] Review Request: python-pyobd - OBD-II (SAE-J1979) compliant scantool software

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1481645



--- Comment #5 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> ---
(In reply to Petr Viktorin from comment #4)
> The first question to ask is: is the Python library useful on its own? Is
> other software expected to import pyobd as a Python module?
> See the relevant [Guidelines].
> Also, are users expected to write Python extensions for pyobd? (In that
> case, the py2/py3 distinction would eventually matter.)
>
I think it may be useful as a module, that's why I created module from it. But
AFAIK nobody use it at the moment.

> 
> If this is an Application that just an application that happens to be
> written in Python. In that case, the name "pyobd" is perfectly fine. Also
> there's no need to provide parallel-installable python2/python3 versions in
> the future: just switch to Python 3 entirely.
> The [Guidelines] cover this case in "Mixed Use Packages": cases 2. and 3.
> seem appropriate -- and note that for case 2. you don't need to do anything
> :)
> 
> If you think of this as a module, *then* the Python packaging guidelines
> apply.
> In that case, the rename could fall under a [FPC exception] for Python SIG,
> so formal re-review might not not needed. Let me know if you want to go that
> way.
> 
> [Guidelines]:
> https://fedoraproject.org/wiki/Packaging:
> Guidelines#Libraries_and_Applications
> [FPC exception]: https://pagure.io/packaging-committee/issue/685

I don't see the FPC exception, the documents you linked only mentions rename of
binary packages. I am trying here to rename the SRPM and request new dist-git
repo for it and there is nothing about it in the docs you linked, so I still
think the need of re-review apply.

Also I think the python packaging guidelines should be updated - the
formulations there are unclear, especially the relation to the
Packaging:Guidelines#Libraries_and_Applications.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux