Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: glglobe - OpenGl Globe - Earth simulation https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249992 mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-08-06 13:35 EST ------- Well, for 0.2-3: * Source1-4 - How did these created? If you downloaded from some URLs, please write the full URLs like Source1. Otherwise please write comments how you created these files. * Desktop file - Categories "X-Red-Hat-Extra X-Red-Hat-Base" are both deprecated and should be removed. * Requires for scriptlets -------------------------------------------------- Requires(post): desktop-file-utils Requires(postun): desktop-file-utils -------------------------------------------------- - are not needed (actually no scriptlets require desktop-file-utils ). * Documents -------------------------------------------------- %install .... mkdir -p %{buildroot}%{_docdir}/glglobe install -p -m 0644 ChangeLog COPYING README TODO %{buildroot}%{_docdir}/glglobe .... %files %doc %{_datadir}/doc/* -------------------------------------------------- - Usually documents must be version specific. Just use: -------------------------------------------------- %doc ChangeLog COPYING README TODO -------------------------------------------------- (and check what actually happens). * desktop-file-utils usage -------------------------------------------------- install -p -m 0644 %{SOURCE4} %{buildroot}%{_datadir}/applications desktop-file-install --vendor fedora --delete-original \ --dir %{buildroot}%{_datadir}/applications \ --add-category X-Red-Hat-Base \ %{buildroot}%{_datadir}/applications/glglobe.desktop ---------------------------------------------------- - This can be replaced by ---------------------------------------------------- desktop-file-install --vendor fedora \ --dir %{buildroot}%{_datadir}/applications \ %{SOURCE4} ---------------------------------------------------- (and remove deprecated categories) * Directory ownership - The directory %{_datadir}/glglobe/ is not owned by any packages - The directories -------------------------------------------------- %{_datadir}/icons/hicolor %{_datadir}/icons/hicolor/* %{_datadir}/icons/hicolor/*/apps -------------------------------------------------- are already owned by hicolor-icon-theme and this package must not own these. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review