https://bugzilla.redhat.com/show_bug.cgi?id=1484561 --- Comment #8 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- (In reply to Richard Kellner from comment #7) > 2) updated all sections, added with -n otherwise it was failing. > > %post -n python3-%{pypi_name} > ... Oh, sorry, I forgot about the -n. > 5) You are right, I have tested systemd and it worked but I forgot to check > that dir, but I didn't spot any issues during the installation or running a > service. Updated to have a ghost dir. More on that in point 6. Generally there would not be any issues. This is just a "good manner". > 6) We also have a ludolph.conf that is supposed to be copied in tmpfiles.d > and once run systemd-tmpfiles --create it would create a directory in /run > (according to ludolph.conf) where service (mentioned in 5) will store PID > file. However, I have struggled with this for a while as fedora wiki > (https://fedoraproject.org/wiki/Packaging:Tmpfiles.d) doesn't mention how to > run systemd-tmpfiles --create I had to look to systemd source code to find > out %tmpfiles_create macro. Not sure if I have permissions for wiki edit but > it would definitely be helpful to mention it in the example. Probably no permissions for either of us. Changes there have to be proposed trough https://pagure.io/packaging-committee/issues > 8) I have almost forgotten about these :) Since it is very difficult to have > a proper test as network connections would require a ton of mocking so there > are only a few tests. I have added > > %check > %{__python2} setup.py test > %{__python3} setup.py test > > This seems to be working fine for python3 all test pass, but python2 does > not execute the tests (not entirely sure why without further inspection). > This way I do not need to introduce any new dependency to the project. Is > this ok? > > I have updated SPEC and SRPM on GitHub, see the latest version there. My > local build is working, but koji builds fail as it seems it can't connect to > PyPI (at the moment, I will try again tommorow): > > Searching for dnspython > Reading https://pypi.python.org/simple/dnspython/ > Download error on https://pypi.python.org/simple/dnspython/: [Errno -2] Name > or service not known -- Some packages may not be found! Koji builds cannot connect to the internet. You want to have all buidrequires specified and run test against stuff installed from RPM packages. It worked for me using: %check %{__python2} -m nose %{__python3} -m nose And adding: BuildRequires: python2-nose BuildRequires: python2-bottle BuildRequires: python2-dns BuildRequires: python2-sleekxmpp BuildRequires: python3-nose BuildRequires: python3-bottle BuildRequires: python3-dns BuildRequires: python3-sleekxmpp -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
