https://bugzilla.redhat.com/show_bug.cgi?id=1484561 --- Comment #7 from Richard Kellner <richard.kellner@xxxxxxxxx> --- 1) removed BuildRequires: systemd so it is there only one. 2) updated all sections, added with -n otherwise it was failing. %post -n python3-%{pypi_name} ... 3) I made python3 package the only one with the service and executable file. This way the python3 package is program and library and python2 package is just library. 4) Removed anyway as it is required only when executing in order to have a running instance. 5) You are right, I have tested systemd and it worked but I forgot to check that dir, but I didn't spot any issues during the installation or running a service. Updated to have a ghost dir. More on that in point 6. 6) We also have a ludolph.conf that is supposed to be copied in tmpfiles.d and once run systemd-tmpfiles --create it would create a directory in /run (according to ludolph.conf) where service (mentioned in 5) will store PID file. However, I have struggled with this for a while as fedora wiki (https://fedoraproject.org/wiki/Packaging:Tmpfiles.d) doesn't mention how to run systemd-tmpfiles --create I had to look to systemd source code to find out %tmpfiles_create macro. Not sure if I have permissions for wiki edit but it would definitely be helpful to mention it in the example. Systemd seems to work fine, even without doing this (conf file and run directory) and systemd is not complaining at all. It seems that it works fine either way, and I can not find even anything that doesn't work in Ludolph without the PID file. So it might be an obsolete code not used anywhere, will do further review and might be deleted in future versions. 7) Default settings have no SELinux issues, I have checked the logs and seems to be ok. I can imagine situations where user configuration can result in SELinux restrictions, but in that case, the user did that on purpose and he has to handle SELinux exceptions. The default is safe without problems. 8) I have almost forgotten about these :) Since it is very difficult to have a proper test as network connections would require a ton of mocking so there are only a few tests. I have added %check %{__python2} setup.py test %{__python3} setup.py test This seems to be working fine for python3 all test pass, but python2 does not execute the tests (not entirely sure why without further inspection). This way I do not need to introduce any new dependency to the project. Is this ok? 9) I have added that in python3 section as it makes sense only there as only this version has the executable script. I have updated SPEC and SRPM on GitHub, see the latest version there. My local build is working, but koji builds fail as it seems it can't connect to PyPI (at the moment, I will try again tommorow): Searching for dnspython Reading https://pypi.python.org/simple/dnspython/ Download error on https://pypi.python.org/simple/dnspython/: [Errno -2] Name or service not known -- Some packages may not be found! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
