https://bugzilla.redhat.com/show_bug.cgi?id=1433617 Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mavit@xxxxxxxxxxxx, | |quantum.analyst@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |quantum.analyst@xxxxxxxxx Flags| |fedora-review? | |needinfo?(mavit@xxxxxxxxx.u | |k) --- Comment #7 from Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> --- I'm not really seeing anything in the readme that indicates that this can be used as a library, nor much documentation of an API. Thus it should probably be treated as an application. However, being treated as an application means not only does it not require the python[23]- prefix, it should not have a python- prefix either. There is also no reason to package a Python 2 version either. You can rename to proselint and drop all python2- BR/R. Also don't need %{pypi_name} macro since you can use %{name} then. Some rpmlint warnings: python3-proselint.noarch: W: hidden-file-or-dir /usr/lib/python3.6/site-packages/proselint/.proselintrc proselint supports reading its defaults from /etc/proselintrc, so I suggest moving this file there instead. python3-proselint.noarch: E: non-executable-script * python3-proselint.noarch: E: wrong-script-interpreter * You've already sent a patch upstream, so might as well apply it here. Same for the broken test, probably. Spelling errors are superfluous. Testing line is very long; consider breaking lines with \-continuation. fedora-review output on the latest version is pretty consistent with Yatin's output, so I'm not going to bother posting it again here. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
