https://bugzilla.redhat.com/show_bug.cgi?id=1481237 Raphael Groner <projects.rg@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |projects.rg@xxxxxxxx --- Comment #1 from Raphael Groner <projects.rg@xxxxxxxx> --- Some general comments to your spec file: - Have you tried to send the patches to upstream? If yes, please note in a comment and you should add comments what those patches do. - According to the python guidelines, the subpackage must be called python2-cmu-ipc instead of cmu-ipc-python2. - Is it possible to build for python3, too? - Descriptions must split into several lines with line feeds. - Please use BR: java-devel instead of explicitly enforce java version 1.8 . - According to our java guidelines, add to the java subpackage: Require: java-headless - In %build you can use one line '%make_build install -S -C src' instead of additional cd . - Why is there no install script provided by upstream? Did you ask for some? - Changelog format is wrong. Must remove the single dash at the end and add a leading dash before the comment. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
