https://bugzilla.redhat.com/show_bug.cgi?id=1432993 --- Comment #11 from srakitnican <samuel.rakitnican@xxxxxxxxx> --- (In reply to Randy Barlow from comment #9) > Created attachment 1308835 [details] > review.txt > > There are a couple of things that must be fixed for approval, and a couple > of optional suggestions. These two must be fixed: > > * The package needs to require systemd and logrotate, since it depends on > directories provided by those packages. Done > * The changelog's newest entry is for release -2, but the current release is > -3. > Please ensure that there is a changelog entry for the current release. Summited the incomplete srpm to soon. The new one should contain all the entries. > * You could easily eliminate the rpmlint warnings: > - Change scsi to SCSI in the description. scsi in "scsi-idle" seems like a naming reference which is all in lower case. I am not sure changing it is the correct thing to do. Spec URL: https://copr-be.cloud.fedoraproject.org/results/srakitnican/default/fedora-26-i386/00586353-hd-idle/hd-idle.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/srakitnican/default/fedora-26-i386/00586353-hd-idle/hd-idle-1.05-4.fc26.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
