[Bug 1432993] Review Request: hd-idle - Spin down idle [USB] hard disks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1432993

srakitnican <samuel.rakitnican@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(samuel.rakitnican |
                   |@gmail.com)                 |



--- Comment #10 from srakitnican <samuel.rakitnican@xxxxxxxxx> ---
(In reply to Randy Barlow from comment #9)
> * fedora-review things that the BuildRequire on gcc is not needed.

Hmm, Packaging Guidelines says differently, maybe rpmlint is wrong?
    https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B

> If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Those packages will include everything that is required to build a standards conforming C or C++ application.


> * You could easily eliminate the rpmlint warnings:
>   - Change scsi to SCSI in the description.

On a second look, second and third paragraph seems more like documentation then
description, how about I drop them completely?

> * I recommend sending a patch to upstream to correct the FSF address in the
>   license file. This would fix the rpmlint error.

I've contacted the author already, I'll see about sending a patch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux