https://bugzilla.redhat.com/show_bug.cgi?id=1431748 --- Comment #7 from Fabio Valentini <decathorpe@xxxxxxxxx> --- > - The Spec file differs from the one in the SRPM. I don't know how this happened, but it should be fixed now. > - As per the golang packaging guidelines draft, it would be nice to rename the package or Provide the application name (ql) [1]. I've added a "Provides: ql" to the package (nothing else provides it - I checked). > - License and documentation files should also be shipped with the main package. You're right, of course. It's fixed now. > - The License tag for Apache Software License 2.0 is 'ASL 2.0' [3]. The ASL 2.0 licese text should also be shipped if you are bundling the go4/lock. Although the best thing to do here would be to find a way to un-bundle the go4/lock from the project (there is only one file importing it - file.go) and remove the ASL 2.0 from the License tag. Maybe you could talk to upstram about it (but it does not seem it would be that hard to patch it)... See [4] and [5] for reference. - The License tag is fixed. - The License file is now included as LICENSE.camlistore-go4-lock - I've tried de-bundling the go4 package, but it's just not possible for me to do that (countless new dependencies, and the source repo has moved from github to a third-party site). Additionally, they state this in their project's README [1]: > - no backwards compatibility. go4 makes no backwards compatibility promises. If you want to use go4, vendor it. [1]: https://github.com/camlistore/go4/blob/master/README.md I added "Provides: bundled(github.com/camlistore/go4/lock)" to the -devel subpackage, since that's the only sensible course of action I see. > - When you bump a post-release vcs revision, you should also bump the package release (see the spec changelog) [2]. Those guidelines are stupid. Why make the (always incrementing) date the first field of the VCS info, if I have to bump the "release" number regardless? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
