[Bug 1431748] Review Request: golang-github-cznic-ql - Embedded SQL database written in Go

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1431748



--- Comment #6 from Athos Ribeiro <athoscribeiro@xxxxxxxxx> ---
Hi Fabio, here we go:

- The Spec file differs from the one in the SRPM.

- As per the golang packaging guidelines draft, it would be nice to rename the
package or Provide the application name (ql) [1].

- License and documentation files should also be shipped with the main package.

- The License tag for Apache Software License 2.0 is 'ASL 2.0' [3]. The ASL 2.0
licese text should also be shipped if you are bundling the go4/lock. Although
the best thing to do here would be to find a way to un-bundle the go4/lock from
the project (there is only one file importing it - file.go) and remove the ASL
2.0 from the License tag. Maybe you could talk to upstram about it (but it does
not seem it would be that hard to patch it)... See [4] and [5] for reference.

- When you bump a post-release vcs revision, you should also bump the package
release (see the spec changelog) [2].

[1] https://fedoraproject.org/wiki/PackagingDrafts/Go#Packaging_Binaries
[2]
https://fedoraproject.org/wiki/Package_Versioning_Examples#Complex_versioning_examples
[3] https://fedoraproject.org/wiki/Licensing:Main#Good_Licenses
[4]
https://fedoraproject.org/wiki/Packaging:Guidelines#Bundling_and_Duplication_of_system_libraries
[5] https://fedoraproject.org/wiki/PackagingDrafts/Go#Bundled_or_de-bundled

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux